Conversation
|
|
AlessandroLupo
requested changes
Feb 16, 2026
AlessandroLupo
left a comment
AlessandroLupo
left a comment
There was a problem hiding this comment.
Nice work! :D I added a couple of comments. Please make sure that your commit messages follow the guidelines. 👍
estate/models/__init__.py
Outdated
| # -*- coding: utf-8 -*- | ||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
|
|
||
| from . import estate_property No newline at end of file |
There was a problem hiding this comment.
Remember to add an empty line at the end of each file ;)
| garden_orientation = fields.Selection( | ||
| string='Type', | ||
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')], | ||
| help="Type is used to choose the orientation") |
There was a problem hiding this comment.
I suppose that you followed this example. Just to be clear: 'Type' in string='Type' is not a special keyword. You can use a more specific string, for example "Garden Orientation". 👍
coder-odoo
force-pushed
the
19.0-Tutorials-coder
branch
from
91e995b to
34e5c4f
Compare
AlessandroLupo
left a comment
AlessandroLupo
left a comment
There was a problem hiding this comment.
Thanks for the changes, it looks fine now! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.